mirror of
https://github.com/arsenetar/send2trash.git
synced 2026-01-22 14:41:40 +00:00
tests: Cleanup some pylint errors and share common fixture
- Cleanup some of the pylint erros in the tests - Reorganize some of the tests functions and fixtures - Move the one common fixture to conftest.py for sharing
This commit is contained in:
GitHub
@@ -2,56 +2,98 @@
|
||||
import os
|
||||
import shutil
|
||||
import sys
|
||||
import pytest
|
||||
from os import path as op
|
||||
|
||||
import pytest
|
||||
from send2trash import send2trash as s2t
|
||||
|
||||
# import the two versions as well as the "automatic" version
|
||||
if sys.platform == "win32":
|
||||
s2t_modern = None
|
||||
s2t_legacy = None
|
||||
|
||||
if sys.platform != "win32":
|
||||
pytest.skip("Skipping windows-only tests", allow_module_level=True)
|
||||
else:
|
||||
# import the two versions as well as the "automatic" version
|
||||
from send2trash.win.modern import send2trash as s2t_modern
|
||||
from send2trash.win.legacy import send2trash as s2t_legacy
|
||||
else:
|
||||
pytest.skip("Skipping windows-only tests", allow_module_level=True)
|
||||
|
||||
if s2t_modern is None:
|
||||
pytest.fail("Modern send2trash not available")
|
||||
|
||||
if s2t_legacy is None:
|
||||
pytest.fail("Legacy send2trash not available")
|
||||
|
||||
|
||||
def _create_tree(path):
|
||||
dirname = op.dirname(path)
|
||||
if not op.isdir(dirname):
|
||||
os.makedirs(dirname)
|
||||
with open(path, "w") as writer:
|
||||
dir_name = op.dirname(path)
|
||||
if not op.isdir(dir_name):
|
||||
os.makedirs(dir_name)
|
||||
with open(path, "w", encoding="utf-8") as writer:
|
||||
writer.write("send2trash test")
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def testdir(tmp_path):
|
||||
dirname = "\\\\?\\" + str(tmp_path)
|
||||
assert op.exists(dirname) is True
|
||||
yield dirname
|
||||
shutil.rmtree(dirname, ignore_errors=True)
|
||||
@pytest.fixture(name="test_dir")
|
||||
def fixture_test_dir(tmp_path):
|
||||
dir_name = "\\\\?\\" + str(tmp_path)
|
||||
assert op.exists(dir_name) is True
|
||||
yield dir_name
|
||||
shutil.rmtree(dir_name, ignore_errors=True)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def testfile(testdir):
|
||||
file = op.join(testdir, "testfile.txt")
|
||||
@pytest.fixture(name="test_file")
|
||||
def fixture_test_file(test_dir):
|
||||
file = op.join(test_dir, "testfile.txt")
|
||||
_create_tree(file)
|
||||
assert op.exists(file) is True
|
||||
yield file
|
||||
# Note dir will cleanup the file
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def testfiles(testdir):
|
||||
files = [op.join(testdir, "testfile{}.txt".format(index)) for index in range(10)]
|
||||
[_create_tree(file) for file in files]
|
||||
assert all([op.exists(file) for file in files]) is True
|
||||
@pytest.fixture(name="test_files")
|
||||
def fixture_test_files(test_dir):
|
||||
files = [op.join(test_dir, f"testfile{index}.txt") for index in range(10)]
|
||||
for file in files:
|
||||
_create_tree(file)
|
||||
assert all(op.exists(file) for file in files) is True
|
||||
yield files
|
||||
# Note dir will cleanup the files
|
||||
|
||||
|
||||
def _trash_folder(dir, fcn):
|
||||
fcn(dir)
|
||||
assert op.exists(dir) is False
|
||||
# Long path tests
|
||||
@pytest.fixture(name="long_dir")
|
||||
def fixture_long_dir(tmp_path):
|
||||
dir_name = "\\\\?\\" + str(tmp_path)
|
||||
name = "A" * 100
|
||||
yield op.join(dir_name, name, name, name)
|
||||
try:
|
||||
shutil.rmtree(dir_name, ignore_errors=True)
|
||||
except TypeError:
|
||||
pass
|
||||
|
||||
|
||||
@pytest.fixture(name="long_file")
|
||||
def fixture_long_file(long_dir):
|
||||
name = "A" * 100
|
||||
path = op.join(long_dir, name + "{}.txt")
|
||||
file = path.format("")
|
||||
_create_tree(file)
|
||||
assert op.exists(file) is True
|
||||
yield file
|
||||
|
||||
|
||||
@pytest.fixture(name="long_files")
|
||||
def fixture_long_files(long_dir):
|
||||
name = "A" * 100
|
||||
path = op.join(long_dir, name + "{}.txt")
|
||||
files = [path.format(index) for index in range(10)]
|
||||
for file in files:
|
||||
_create_tree(file)
|
||||
assert all(op.exists(file) for file in files) is True
|
||||
yield files
|
||||
|
||||
|
||||
def _trash_folder(folder, fcn):
|
||||
fcn(folder)
|
||||
assert op.exists(folder) is False
|
||||
|
||||
|
||||
def _trash_file(file, fcn):
|
||||
@@ -61,160 +103,113 @@ def _trash_file(file, fcn):
|
||||
|
||||
def _trash_multifile(files, fcn):
|
||||
fcn(files)
|
||||
assert any([op.exists(file) for file in files]) is False
|
||||
assert any(op.exists(file) for file in files) is False
|
||||
|
||||
|
||||
def _file_not_found(dir, fcn):
|
||||
file = op.join(dir, "otherfile.txt")
|
||||
def _file_not_found(folder, fcn):
|
||||
file = op.join(folder, "otherfile.txt")
|
||||
pytest.raises(OSError, fcn, file)
|
||||
|
||||
|
||||
def _multi_byte_unicode(dir, fcn):
|
||||
single_file = op.join(dir, "😇.txt")
|
||||
def _multi_byte_unicode(folder, fcn):
|
||||
single_file = op.join(folder, "😇.txt")
|
||||
_create_tree(single_file)
|
||||
assert op.exists(single_file) is True
|
||||
fcn(single_file)
|
||||
assert op.exists(single_file) is False
|
||||
files = [op.join(dir, "😇{}.txt".format(index)) for index in range(10)]
|
||||
[_create_tree(file) for file in files]
|
||||
assert all([op.exists(file) for file in files]) is True
|
||||
files = [op.join(folder, f"😇{index}.txt") for index in range(10)]
|
||||
for file in files:
|
||||
_create_tree(file)
|
||||
assert all(op.exists(file) for file in files) is True
|
||||
fcn(files)
|
||||
assert any([op.exists(file) for file in files]) is False
|
||||
assert any(op.exists(file) for file in files) is False
|
||||
|
||||
|
||||
def test_trash_folder(testdir):
|
||||
_trash_folder(testdir, s2t)
|
||||
def test_trash_folder(test_dir):
|
||||
_trash_folder(test_dir, s2t)
|
||||
|
||||
|
||||
def test_trash_file(testfile):
|
||||
_trash_file(testfile, s2t)
|
||||
def test_trash_file(test_file):
|
||||
_trash_file(test_file, s2t)
|
||||
|
||||
|
||||
def test_trash_multifile(testfiles):
|
||||
_trash_multifile(testfiles, s2t)
|
||||
def test_trash_multifile(test_files):
|
||||
_trash_multifile(test_files, s2t)
|
||||
|
||||
|
||||
def test_file_not_found(testdir):
|
||||
_file_not_found(testdir, s2t)
|
||||
def test_file_not_found(test_dir):
|
||||
_file_not_found(test_dir, s2t)
|
||||
|
||||
|
||||
def test_trash_folder_modern(testdir):
|
||||
_trash_folder(testdir, s2t_modern)
|
||||
def test_trash_folder_modern(test_dir):
|
||||
_trash_folder(test_dir, s2t_modern)
|
||||
|
||||
|
||||
def test_trash_file_modern(testfile):
|
||||
_trash_file(testfile, s2t_modern)
|
||||
def test_trash_file_modern(test_file):
|
||||
_trash_file(test_file, s2t_modern)
|
||||
|
||||
|
||||
def test_trash_multifile_modern(testfiles):
|
||||
_trash_multifile(testfiles, s2t_modern)
|
||||
def test_trash_multifile_modern(test_files):
|
||||
_trash_multifile(test_files, s2t_modern)
|
||||
|
||||
|
||||
def test_file_not_found_modern(testdir):
|
||||
_file_not_found(testdir, s2t_modern)
|
||||
def test_file_not_found_modern(test_dir):
|
||||
_file_not_found(test_dir, s2t_modern)
|
||||
|
||||
|
||||
def test_multi_byte_unicode_modern(testdir):
|
||||
_multi_byte_unicode(testdir, s2t_modern)
|
||||
|
||||
|
||||
def test_trash_folder_legacy(testdir):
|
||||
_trash_folder(testdir, s2t_legacy)
|
||||
|
||||
|
||||
def test_trash_file_legacy(testfile):
|
||||
_trash_file(testfile, s2t_legacy)
|
||||
|
||||
|
||||
def test_trash_multifile_legacy(testfiles):
|
||||
_trash_multifile(testfiles, s2t_legacy)
|
||||
|
||||
|
||||
def test_file_not_found_legacy(testdir):
|
||||
_file_not_found(testdir, s2t_legacy)
|
||||
|
||||
|
||||
def test_multi_byte_unicode_legacy(testdir):
|
||||
_multi_byte_unicode(testdir, s2t_legacy)
|
||||
|
||||
|
||||
# Long path tests
|
||||
@pytest.fixture
|
||||
def longdir(tmp_path):
|
||||
dirname = "\\\\?\\" + str(tmp_path)
|
||||
name = "A" * 100
|
||||
yield op.join(dirname, name, name, name)
|
||||
try:
|
||||
shutil.rmtree(dirname, ignore_errors=True)
|
||||
except TypeError:
|
||||
pass
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def longfile(longdir):
|
||||
name = "A" * 100
|
||||
path = op.join(longdir, name + "{}.txt")
|
||||
file = path.format("")
|
||||
_create_tree(file)
|
||||
assert op.exists(file) is True
|
||||
yield file
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def longfiles(longdir):
|
||||
name = "A" * 100
|
||||
path = op.join(longdir, name + "{}.txt")
|
||||
files = [path.format(index) for index in range(10)]
|
||||
[_create_tree(file) for file in files]
|
||||
assert all([op.exists(file) for file in files]) is True
|
||||
yield files
|
||||
def test_multi_byte_unicode_modern(test_dir):
|
||||
_multi_byte_unicode(test_dir, s2t_modern)
|
||||
|
||||
|
||||
# NOTE: both legacy and modern test "pass" on windows, however sometimes with the same path
|
||||
# they do not actually recycle files but delete them. Noticed this when testing with the
|
||||
# recycle bin open, noticed later tests actually worked, modern version can actually detect
|
||||
# when this happens but not stop it at this moment, and we need a way to verify it when testing.
|
||||
def test_trash_long_file_modern(longfile):
|
||||
_trash_file(longfile, s2t_modern)
|
||||
def test_trash_long_file_modern(long_file):
|
||||
_trash_file(long_file, s2t_modern)
|
||||
|
||||
|
||||
def test_trash_long_multifile_modern(longfiles):
|
||||
_trash_multifile(longfiles, s2t_modern)
|
||||
|
||||
|
||||
# @pytest.skipif(
|
||||
# op.splitdrive(os.getcwd())[0] != op.splitdrive(gettempdir())[0],
|
||||
# "Cannot trash long path from other drive",
|
||||
# )
|
||||
# def test_trash_long_folder_modern(self):
|
||||
# self._trash_folder(s2t_modern)
|
||||
|
||||
|
||||
def test_trash_long_file_legacy(longfile):
|
||||
_trash_file(longfile, s2t_legacy)
|
||||
|
||||
|
||||
def test_trash_long_multifile_legacy(longfiles):
|
||||
_trash_multifile(longfiles, s2t_legacy)
|
||||
|
||||
|
||||
# @pytest.skipif(
|
||||
# op.splitdrive(os.getcwd())[0] != op.splitdrive(gettempdir())[0],
|
||||
# "Cannot trash long path from other drive",
|
||||
# )
|
||||
# def test_trash_long_folder_legacy(self):
|
||||
# self._trash_folder(s2t_legacy)
|
||||
|
||||
|
||||
def test_trash_nothing_legacy():
|
||||
try:
|
||||
s2t_legacy([])
|
||||
except Exception as ex:
|
||||
assert False, "Exception thrown when trashing nothing: {}".format(ex)
|
||||
def test_trash_long_multifile_modern(long_files):
|
||||
_trash_multifile(long_files, s2t_modern)
|
||||
|
||||
|
||||
def test_trash_nothing_modern():
|
||||
try:
|
||||
s2t_modern([])
|
||||
except Exception as ex:
|
||||
assert False, "Exception thrown when trashing nothing: {}".format(ex)
|
||||
assert False, f"Exception thrown when trashing nothing: {ex}"
|
||||
|
||||
|
||||
def test_trash_folder_legacy(test_dir):
|
||||
_trash_folder(test_dir, s2t_legacy)
|
||||
|
||||
|
||||
def test_trash_file_legacy(test_file):
|
||||
_trash_file(test_file, s2t_legacy)
|
||||
|
||||
|
||||
def test_trash_multifile_legacy(test_files):
|
||||
_trash_multifile(test_files, s2t_legacy)
|
||||
|
||||
|
||||
def test_file_not_found_legacy(test_dir):
|
||||
_file_not_found(test_dir, s2t_legacy)
|
||||
|
||||
|
||||
def test_multi_byte_unicode_legacy(test_dir):
|
||||
_multi_byte_unicode(test_dir, s2t_legacy)
|
||||
|
||||
|
||||
def test_trash_long_file_legacy(long_file):
|
||||
_trash_file(long_file, s2t_legacy)
|
||||
|
||||
|
||||
def test_trash_long_multifile_legacy(long_files):
|
||||
_trash_multifile(long_files, s2t_legacy)
|
||||
|
||||
|
||||
def test_trash_nothing_legacy():
|
||||
try:
|
||||
s2t_legacy([])
|
||||
except Exception as ex:
|
||||
assert False, f"Exception thrown when trashing nothing: {ex}"
|
||||
|
||||
Reference in New Issue
Block a user