Fixed tests.

.hgtags

@@ -65,3 +65,4 @@ a2f7b7302e178f08725a6404ddc28464409510b1 se3.2.0
 015ba7e2c10d09afb944f387c2a9c97f7eff7571 me6.2.0
 8178bda48324461a17118c98634241952c074f29 pe2.4.0
 2a96f2fb3ddb6f1e0ae87951586733fc3e4a28a0 se3.3.2
+6a08c1205dfe5e537e5c2dc99d05e05d1d3928f6 me6.2.1

core/tests/app_test.py

@@ -168,10 +168,10 @@ class TestCaseDupeGuruWithResults:
         self.app = DupeGuru()
         self.objects,self.matches,self.groups = GetTestGroups()
         self.app.results.groups = self.groups
-        self.dpanel_gui = CallLogger()
+        self.dpanel = self.app.details_panel
-        self.dpanel = DetailsPanel(self.dpanel_gui, self.app)
+        self.dpanel.view = CallLogger()
-        self.dtree_gui = CallLogger()
+        self.dtree = self.app.directory_tree
-        self.dtree = DirectoryTree(self.dtree_gui, self.app)
+        self.dtree.view = CallLogger()
         self.rtable_gui = CallLogger()
         self.rtable = self.app.result_table
         self.rtable.view = self.rtable_gui
@@ -299,10 +299,10 @@ class TestCaseDupeGuruWithResults:
     def test_refreshDetailsWithSelected(self, do_setup):
         self.rtable.select([1, 4])
         eq_(self.dpanel.row(0), ('Filename', 'bar bleh', 'foo bar'))
-        self.dpanel_gui.check_gui_calls(['refresh'])
+        self.dpanel.view.check_gui_calls(['refresh'])
         self.rtable.select([])
         eq_(self.dpanel.row(0), ('Filename', '---', '---'))
-        self.dpanel_gui.check_gui_calls(['refresh'])
+        self.dpanel.view.check_gui_calls(['refresh'])
     
     def test_makeSelectedReference(self, do_setup):
         app = self.app
@@ -478,11 +478,11 @@ class TestAppWithDirectoriesInTree:
         io.mkdir(p + 'sub2')
         io.mkdir(p + 'sub3')
         self.app = DupeGuru()
-        self.dtree_gui = CallLogger()
+        self.dtree = self.app.directory_tree
-        self.dtree = DirectoryTree(self.dtree_gui, self.app)
+        self.dtree.view = CallLogger()
         self.dtree.connect()
         self.dtree.add_directory(p)
-        self.dtree_gui.clear_calls()
+        self.dtree.view.clear_calls()
     
     def test_set_root_as_ref_makes_subfolders_ref_as_well(self, do_setup):
         # Setting a node state to something also affect subnodes. These subnodes must be correctly
@@ -495,5 +495,5 @@ class TestAppWithDirectoriesInTree:
         eq_(len(node), 3)
         subnode = node[0]
         eq_(subnode.state, 1)
-        self.dtree_gui.check_gui_calls(['refresh_states'])
+        self.dtree.view.check_gui_calls(['refresh_states'])
     

core/tests/base.py

@@ -52,7 +52,6 @@ class DupeGuru(DupeGuruBase):
     
     def __init__(self):
         DupeGuruBase.__init__(self, DupeGuruView(), '/tmp')
-        self.result_table = ResultTable(self)
     
     def _get_display_info(self, dupe, group, delta):
         size = dupe.size
@@ -79,6 +78,10 @@ class DupeGuru(DupeGuruBase):
     def _prioritization_categories(self):
         return prioritize.all_categories()
     
+    def _create_result_table(self):
+        return ResultTable(self)
+    
+
 class NamedObject:
     def __init__(self, name="foobar", with_words=False, size=1, folder=None):
         self.name = name
@@ -136,11 +139,9 @@ class TestApp(TestAppBase):
         self.app = DupeGuru()
         self.default_parent = self.app
         self.rtable = link_gui(self.app.result_table)
-        make_gui('dtree', DirectoryTree)
+        self.dtree = link_gui(self.app.directory_tree)
-        make_gui('dpanel', DetailsPanel)
+        self.dpanel = link_gui(self.app.details_panel)
-        make_gui('pdialog', PrioritizeDialog)
+        self.pdialog = PrioritizeDialog(self.app)
-        for elem in [self.rtable, self.dtree, self.dpanel]:
-            elem.connect()
     
     #--- Helpers
     def select_pri_criterion(self, name):

core_pe/__init__.py

@@ -1,2 +1,2 @@
-__version__ = '2.4.0'
+__version__ = '2.4.1'
 __appname__ = 'dupeGuru Picture Edition'

help/changelog_pe

@@ -1,3 +1,10 @@
+=== 2.4.1 (2012-01-23)
+
+* Fixed a crash on sorting by dimensions.
+* Improved communications with iPhoto. [Cocoa] (#185)
+* Fixed crash on Export to HTML. [Windows, Linux]
+* Added Ukrainian localization by Yuri Petrashko.
+
 === 2.4.0 (2012-01-06)
 
 * Added multiple-selection in folder selection dialog for a more efficient folder removal. (#179)

help/en/changelog.tmpl

@@ -3,4 +3,10 @@
 Changelog
 =========
 
+**About the word "crash":** When reading this changelog, you might be alarmed at the number of fixes
+for "crashes". Be aware that when the word "crash" is used here, it refers to "soft crashes" which
+don't cause the application to quit. You simply get an error window that asks you if you want to
+send the crash report to Hardcoded Software. Crashes that cause the application to quit are called
+"hard crashes" in this changelog.
+
 {changelog}

requirements-osx.txt

@@ -1,4 +1,4 @@
 -r requirements.txt
-objp>=1.0.0
+objp>=1.1.0
 pluginbuilder>=1.1.0
 appscript>=1.0.0