From fbe66d27c93525a041dc77cbaf82f484f1fd4045 Mon Sep 17 00:00:00 2001 From: Virgil Dupras Date: Mon, 28 Nov 2011 13:14:36 -0500 Subject: [PATCH] [#178 state:fixed] Fixed a crash on adding a criterion with an empty selection. --- core/gui/prioritize_dialog.py | 2 ++ core/tests/prioritize_test.py | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/core/gui/prioritize_dialog.py b/core/gui/prioritize_dialog.py index d68c6b7d..d458f6cb 100644 --- a/core/gui/prioritize_dialog.py +++ b/core/gui/prioritize_dialog.py @@ -61,6 +61,8 @@ class PrioritizeDialog: def add_selected(self): # Add selected criteria in criteria_list to prioritization_list. + if self.criteria_list.selected_index is None: + return crit = self.criteria[self.criteria_list.selected_index] self.prioritizations.append(crit) self.prioritization_list[:] = [crit.display for crit in self.prioritizations] diff --git a/core/tests/prioritize_test.py b/core/tests/prioritize_test.py index 440d5183..ac3a0365 100644 --- a/core/tests/prioritize_test.py +++ b/core/tests/prioritize_test.py @@ -123,6 +123,11 @@ def test_remove_crit_from_list(app): ] eq_(app.pdialog.prioritization_list[:], expected) +@with_app(app_normal_results) +def test_add_crit_without_selection(app): + # Adding a criterion without having made a selection doesn't cause a crash. + app.pdialog.add_selected() # no crash + #--- def app_one_name_ends_with_number(): dupes = [