More Cleanups

- Remove seperate hscommon submodule, and use the files in the dupeguru submodule
- Update package.py and build.py to account for hscommon submodule removal
- Fix one more warning in UI code
- Update .gitignore to ignore visual studio code folder
This commit is contained in:
Andrew Senetar 2020-12-29 21:36:05 -06:00
parent 2eada16210
commit caac8df893
No known key found for this signature in database
GPG Key ID: FEB896EB6CF6254B
6 changed files with 10 additions and 7 deletions

2
.gitignore vendored
View File

@ -13,6 +13,8 @@ __pycache__
/cocoa/*.lproj/*.strings
!/cocoa/Base.lproj/Localizable.strings
.vscode
# Xcode
*.xcworkspace
!default.xcworkspace

3
.gitmodules vendored
View File

@ -1,6 +1,3 @@
[submodule "dupeguru"]
path = dupeguru
url = https://github.com/hsoft/dupeguru.git
[submodule "hscommon"]
path = hscommon
url = https://github.com/hsoft/hscommon.git

View File

@ -90,7 +90,7 @@ def build_cocoa(dev):
os.mkdir(pydep_folder)
shutil.copy(op.join(cocoa_project_path, 'dg_cocoa.py'), 'build')
tocopy = [
'dupeguru/core', 'hscommon', 'cocoa/inter', 'cocoalib/cocoa', 'objp', 'send2trash', 'hsaudiotag',
'dupeguru/core', 'dupeguru/hscommon', 'cocoa/inter', 'cocoalib/cocoa', 'objp', 'send2trash', 'hsaudiotag',
]
copy_packages(tocopy, pydep_folder, create_links=dev)
sys.path.insert(0, 'build')

View File

@ -38,6 +38,6 @@ http://www.gnu.org/licenses/gpl-3.0.html
- (IBAction)close:(id)sender
{
[[self window] orderOut:self];
[NSApp stopModalWithCode:NSOKButton];
[NSApp stopModalWithCode:NSModalResponseOK];
}
@end

@ -1 +0,0 @@
Subproject commit a56aee2f08becba9b968ff96caa3a7f6651a4c74

View File

@ -6,6 +6,11 @@
from argparse import ArgumentParser
# Modify the python path so the hscommon files in the dupeguru submodule may be used
import sys
import os
sys.path.append(os.path.join(os.getcwd(), 'dupeguru'))
from hscommon.build import setup_package_argparser, package_cocoa_app_in_dmg
def parse_args():
@ -14,7 +19,7 @@ def parse_args():
return parser.parse_args()
def package_cocoa(args):
app_path = 'build/dupeGuru.app'
app_path = 'build/Release/dupeGuru.app'
package_cocoa_app_in_dmg(app_path, '.', args)
def main():